Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: text layer accepts font filename again #1828

Merged
merged 1 commit into from Nov 9, 2020

Conversation

rodolforg
Copy link
Contributor

closes #1766

@rodolforg
Copy link
Contributor Author

Please cherry-pick to 1.3.x branch as it's a regression :P

Sorry my mistake

@ice0 ice0 added the Backport label Nov 9, 2020
@ice0
Copy link
Collaborator

ice0 commented Nov 9, 2020

Added backport label, now @morevnaproject can easily filter PR that needs backporting.

@ice0 ice0 merged commit dbde6c6 into synfig:master Nov 9, 2020
@ice0
Copy link
Collaborator

ice0 commented Nov 9, 2020

Merged. Thank you!

@rodolforg
Copy link
Contributor Author

Added backport label, now @morevnaproject can easily filter PR that needs backporting.

@morevnaproject please don't forget to filter by Backport lable for open and closed PR XD

@rodolforg
Copy link
Contributor Author

Whoops. This problem doesn't happen in 1.3.x :P

@morevnaproject
Copy link
Member

I think this problem might appear in 1.4.x branch as soon as I backport latest Text Layer changes there. So, let's leave the "Backport" label on this PR. ^__^

@morevnaproject
Copy link
Member

as soon as I backport latest Text Layer changes there

I do not remember which PR I was about to backport 😭

@rodolforg
Copy link
Contributor Author

@morevnaproject maybe you could check via git log synfig-core/src/modules/lyr_freetype/ the last commits of a branch and another :P
Would it be about font caching or combobox for font family support?

@rodolforg
Copy link
Contributor Author

https://github.com/synfig/synfig/pulls?q=is%3Apr+is%3Aclosed+freetype+

@morevnaproject
Copy link
Member

Thank you! I have looked through them and I couldn't find the issue I looking for ^__^". I remember we had a discussion there about backporting, but I couldn't find those messages now. Well, anyway I remember there were problems with backporting (some conflicts), which was prevented me from cherry-picking that PR into 1.4.x...

@rodolforg rodolforg deleted the last-fix-1766 branch November 15, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select "Font Family" on Windows builds
3 participants