[ETL] current_working_directory() function now works correctly with non-Latin filenames #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-Latin filenames
rodolforg
approved these changes
Feb 6, 2021
There was a problem hiding this comment.
I really don't like to make libsynfig (more) dependent on glibmm, it prevents to use libsynfig on simpler projects (like embed it on Godot Engine or maybe some Android projects).
Maybe use iconv to convert utf-16 to utf-8 (on windows) would solve this issue.
Anyway, it isn't a reality right now. So, ok.
Merged
ice0
added a commit
to ice0/synfig
that referenced
this pull request
Feb 28, 2021
…on-Latin filenames (synfig#2011) (cherry picked from commit 94c0805)
ice0
added a commit
to ice0/synfig
that referenced
this pull request
Feb 28, 2021
…on-Latin filenames (synfig#2011) (cherry picked from commit 94c0805)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
…on-Latin filenames (synfig#2011) (cherry picked from commit 94c0805)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
…on-Latin filenames (synfig#2011) (cherry picked from commit 94c0805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem mentioned by @rodolforg here: #1952, so I fixed it.