Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash of test on Void Linux #2265

Merged
merged 1 commit into from Oct 3, 2021
Merged

Fixed crash of test on Void Linux #2265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion synfig-studio/src/synfigapp/actions/layerduplicate.cpp
View file
Open in desktop
Expand Up @@ -416,7 +416,11 @@ LayerDuplicate::replace_valuenodes(const std::map<synfig::Layer::Handle,synfig::

auto cloned_layer = layer_pair.second;

for(auto iter=cloned_layer->dynamic_param_list().cbegin();iter!=cloned_layer->dynamic_param_list().cend();++iter)
// disconnect_dynamic_param/connect_dynamic_param can change dynamic_param_list() while iterating
// which makes iter invalid, so we create a copy of dynamic_param_list() first
auto param_list = cloned_layer->dynamic_param_list();

for (auto iter=param_list.cbegin();iter!=param_list.cend();++iter)
{
for (const auto& vn_pair : cloned_valuenode_map) {
if (iter->second == vn_pair.first) {
Expand Down