Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ability to show/hide rulers #2634

Merged
merged 13 commits into from Aug 26, 2022
Merged

feat: added ability to show/hide rulers #2634

merged 13 commits into from Aug 26, 2022

Commits on May 16, 2022

  1. patch

    @mohamedAdhamc
    mohamedAdhamc committed May 16, 2022
    Copy the full SHA
    0f186f4 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. patch 

    removed duplicated code, by making the menubutton_box a class member
    @mohamedAdhamc
    mohamedAdhamc committed May 17, 2022
    Copy the full SHA
    ece4418 View commit details
    Browse the repository at this point in the history

  2. fix 

    regular show()/hide()
    @mohamedAdhamc
    mohamedAdhamc committed May 17, 2022
    Copy the full SHA
    2e3f9e1 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. simplified 

    simplified even more and changed name as suggested. will be working in about an hour on saving the ruler status in the settings files, then starting with the gtk::arrow replacement
    @mohamedAdhamc
    mohamedAdhamc committed May 18, 2022
    Copy the full SHA
    c36645c View commit details
    Browse the repository at this point in the history

  2. settings saved

    @mohamedAdhamc
    mohamedAdhamc committed May 18, 2022
    Copy the full SHA
    41be5c5 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. menu check button added 

    added and synced with the tool button
    @mohamedAdhamc
    mohamedAdhamc committed May 26, 2022
    Copy the full SHA
    a84a633 View commit details
    Browse the repository at this point in the history

  2. icon + tool tip

    @mohamedAdhamc
    mohamedAdhamc committed May 26, 2022
    Copy the full SHA
    c0c01c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. removed button

    @mohamedAdhamc
    mohamedAdhamc committed Jul 21, 2022
    Copy the full SHA
    27827a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. removing no longer needed boolean 

    was needed when there was a button along with it now not needed
    @mohamedAdhamc
    mohamedAdhamc committed Jul 22, 2022
    Copy the full SHA
    94801a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. changed naming as requested

    @mohamedAdhamc
    mohamedAdhamc committed Aug 15, 2022
    Copy the full SHA
    0d8e71f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. removed unnecessary comm + spacing

    @mohamedAdhamc
    mohamedAdhamc committed Aug 17, 2022
    Copy the full SHA
    75647c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. addressing req changes 

    1- removed toggle ruler
2- removed unneeded set_ruler_show_toggle
3- changed `set_ruler_visible` to `set_show_rulers`
    @mohamedAdhamc
    mohamedAdhamc committed Aug 26, 2022
    Copy the full SHA
    51d29e1 View commit details
    Browse the repository at this point in the history

  2. removing forgotten comment

    @mohamedAdhamc
    mohamedAdhamc committed Aug 26, 2022
    Copy the full SHA
    9e88055 View commit details
    Browse the repository at this point in the history