fix: some icons didn't follow icon theme #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodolforg
force-pushed
the
fix-icons-didnt-follow-icon-theme
branch
2 times, most recently
from
6562327
to
77a1984
Compare
ice0
reviewed
Jun 20, 2023
Reported-by: pablogil Via: https://forums.synfig.org/t/modern-iconset-light-and-dark/13560/31
* Select All Child Layers * Undo * Redo * Clear Undo * Clear Redo Reported-by: pablogil Via: https://forums.synfig.org/t/modern-iconset-light-and-dark/13560/31
* New * Open * Save All Reported-by: pablogil Via: https://forums.synfig.org/t/modern-iconset-light-and-dark/13560/31
rodolforg
force-pushed
the
fix-icons-didnt-follow-icon-theme
branch
from
77a1984
to
7056171
Compare
ice0
approved these changes
Jun 21, 2023
|
Merged. Thank you! |
|
I finally had the time to try the fix: it works like a charm =D Thanks |
Closed
|
As I reported in #3116 (maybe too soonish as the PR hasn't been merged yet...) I found that some "delete" icons are gone. I had time to test it by myself and found out that the problem was some references changed to "gtk-delete" while the correct one should be "edit-delete" as it's the only one that seems to be used in Synfig.
But keep "edit-delete" in |
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Jul 17, 2023
After commit 4e7a9f3 (PR synfig#3109) If set, related action tooltip overrides the query_tooltip slot.
ice0
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: pablogil
Via: https://forums.synfig.org/t/modern-iconset-light-and-dark/13560/31