Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File/path handling is broken on Windows #100

Closed
synfinatic opened this issue Nov 2, 2021 · 0 comments · Fixed by #103
Closed

File/path handling is broken on Windows #100

synfinatic opened this issue Nov 2, 2021 · 0 comments · Fixed by #103
Labels
bug Something isn't working
Milestone
1.2.1

Comments

@synfinatic
Copy link
Owner

All my code uses / instead of \.
@synfinatic synfinatic added the bug Something isn't working label Nov 2, 2021
@synfinatic synfinatic added this to the 1.2.1 milestone Nov 2, 2021
@synfinatic synfinatic mentioned this issue Nov 2, 2021
Closed
synfinatic added a commit that referenced this issue Nov 3, 2021
@synfinatic
Fix GetHomePath
d585a80 
 - Make it work on Windows and other systems without $HOME
 - Use correct path separator based on OS
 - Add/fix unit tests

Fixes: #100
@synfinatic synfinatic mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Fix GetHomePath synfinatic/aws-sso-cli
1 participant
@synfinatic