Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing settings from the config file are not removed from the cache via cache #254

Closed
synfinatic opened this issue Jan 16, 2022 · 0 comments · Fixed by #256
Closed

Removing settings from the config file are not removed from the cache via cache #254

synfinatic opened this issue Jan 16, 2022 · 0 comments · Fixed by #256
Labels
bug Something isn't working
Milestone
1.7.1

Comments

@synfinatic
Copy link
Owner

basically, we don't remove settings (like a custom Profile) from the cache when we remove that from the config.yaml because the two are merged. So when calling cache we need a different logic that doesn't use the existing cache records for the specified sso instance.
@synfinatic synfinatic added the bug Something isn't working label Jan 16, 2022
@synfinatic synfinatic added this to the 1.7.1 milestone Jan 16, 2022
synfinatic added a commit that referenced this issue Jan 16, 2022
@synfinatic
refresh cache will remove old data and keep history
692422e 
Fixes two issues with the `cache` command:
1. History records were being incorrectly deleted before expire
2. Were not removing old settings copied from config so they would stick
   around

Fixes: #254
@synfinatic synfinatic mentioned this issue Jan 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

refresh cache will remove old data and keep history synfinatic/aws-sso-cli
1 participant
@synfinatic