Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New config is generating maxretry/maxbackoff = 0 #536

Closed
synfinatic opened this issue Aug 16, 2023 · 0 comments · Fixed by #538
Closed

New config is generating maxretry/maxbackoff = 0 #536

synfinatic opened this issue Aug 16, 2023 · 0 comments · Fixed by #538
Labels
bug Something isn't working
Milestone
v1.13.0

Comments

@synfinatic
Copy link
Owner

Output of aws-sso version:

Example output:
AWS SSO CLI Version 1.12.0 -- Copyright 2021 Aaron Turner

Describe the bug:

Users running aws-sso config end up with invalid values:

SSOConfig:
  Default:
    SSORegion: us-east-1
    StartUrl: https://foo.awsapps.com/start
    maxbackoff: 0
    maxretry: 0
@synfinatic synfinatic added the bug Something isn't working label Aug 16, 2023
@synfinatic synfinatic added this to the v1.13.0 milestone Aug 16, 2023
synfinatic added a commit that referenced this issue Aug 16, 2023
@synfinatic
Do not generate bogus config statements
36f0c50 
The `maxretry` and `maxbackoff` are not config options
exposed a the SSO Instance layer and should not generate
entries in the config during `aws-sso config`

Fixes: #536
@synfinatic synfinatic mentioned this issue Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

Do not generate bogus config statements synfinatic/aws-sso-cli
1 participant
@synfinatic