Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't prompt to backup non-existent config files #537

Closed
synfinatic opened this issue Aug 16, 2023 · 0 comments · Fixed by #539
Closed

don't prompt to backup non-existent config files #537

synfinatic opened this issue Aug 16, 2023 · 0 comments · Fixed by #539
Labels
bug Something isn't working
Milestone
v1.13.0

Comments

@synfinatic
Copy link
Owner

Output of aws-sso version:

AWS SSO CLI Version 1.12.0 -- Copyright 2021 Aaron Turner

Describe the bug:
during initial setup or the config command, it should only prompt to backup the config file if it already exists.

To Reproduce:
rm -f foo.yaml && aws-sso config --config foo.yaml

Expected behavior:

no prompting to backup config file
@synfinatic synfinatic added the bug Something isn't working label Aug 16, 2023
@synfinatic synfinatic added this to the v1.13.0 milestone Aug 16, 2023
synfinatic added a commit that referenced this issue Aug 17, 2023
@synfinatic
don't prompt to backup missing files
cced876 
- avoid running the configurator twice
- exit when user does a Ctrl-C during the guided setup

Fixes: #537
@synfinatic synfinatic mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

don't prompt to backup missing files synfinatic/aws-sso-cli
1 participant
@synfinatic