Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returned ECS creds should include RoleArn #561

Closed
synfinatic opened this issue Aug 27, 2023 · 0 comments · Fixed by #562
Closed

Returned ECS creds should include RoleArn #561

synfinatic opened this issue Aug 27, 2023 · 0 comments · Fixed by #562
Labels
bug Something isn't working
Milestone
v1.13.1

Comments

@synfinatic
Copy link
Owner

Missing ReleArn per: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html
@synfinatic synfinatic added the bug Something isn't working label Aug 27, 2023
@synfinatic synfinatic added this to the v1.13.1 milestone Aug 27, 2023
@synfinatic synfinatic changed the title Returned ECS creds should include ReleArn Returned ECS creds should include RoleArn Aug 27, 2023
synfinatic added a commit that referenced this issue Aug 27, 2023
@synfinatic
Include RoleArn and invalid bad routes
312e97c 
- Returned credentials via ECS server now include the RoleARN
- Bad paths processed by the default route now return a 404

Fixes: #561
@synfinatic synfinatic mentioned this issue Aug 27, 2023
Merged
synfinatic added a commit that referenced this issue Aug 27, 2023
@synfinatic
Include RoleArn and invalid bad routes
a1abf26 
- Returned credentials via ECS server now include the RoleARN
- Bad paths processed by the default route now return a 404

Fixes: #561
synfinatic added a commit that referenced this issue Aug 27, 2023
@synfinatic
Include RoleArn and invalid bad routes
a6ae072 
- Improve ecs-server docs
- Returned credentials via ECS server now include the RoleARN
- Bad paths processed by the default route now return a 404

Fixes: #561
synfinatic added a commit that referenced this issue Aug 27, 2023
@synfinatic
Include RoleArn and invalid bad routes
f54b139 
- Improve ecs-server docs
- Returned credentials via ECS server now include the RoleARN
- Bad paths processed by the default route now return a 404

Fixes: #561
synfinatic added a commit that referenced this issue Aug 27, 2023
@synfinatic
Include RoleArn and invalid bad routes
db06722 
- Improve ecs-server docs
- Returned credentials via ECS server now include the RoleARN
- Bad paths processed by the default route now return a 404

Fixes: #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13.1
Development

Successfully merging a pull request may close this issue.

Include RoleArn and invalid bad routes synfinatic/aws-sso-cli
1 participant
@synfinatic