Fix AWS_SSO_SESSION_EXPIRATION with Via #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assuming a role, via `Via` the AWS_SSO_SESSION_EXPIRATION would incorrectly report a date in the past instead of the future because we were specifying secs instead of msec. Fixes: #250
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 45.03% 45.03%
=======================================
Files 11 11
Lines 1781 1781
=======================================
Hits 802 802
Misses 915 915
Partials 64 64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assuming a role, via
Viathe AWS_SSO_SESSION_EXPIRATIONwould incorrectly report a date in the past instead of the
future because we were specifying secs instead of msec.
Fixes: #250