Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inital setup #378

Merged
merged 1 commit into from May 7, 2022
Merged

fix inital setup #378

merged 1 commit into from May 7, 2022

Conversation

synfinatic
Copy link
Owner

  • Fix some bugs during intial setup
  • Fix default ProfileFormat now that colons are okay again
  • Include omitempty as appropriate in some Settings
  • Fix backup of config file on reconfig
  • Rename reconfig to just config

@synfinatic synfinatic added this to the 1.9.0 milestone May 7, 2022
- Fix some bugs during intial setup
- Fix default ProfileFormat now that colons are okay again
- Include omitempty as appropriate in some Settings
- Fix backup of config file on reconfig
- Rename `reconfig` to just `config`
- Migrate ConfigUrlAction => ConfigProfilesUrlAction if we save the
    config file
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #378 (65d3980) into main (59714cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   75.96%   75.97%   +0.01%     
==========================================
  Files          17       17              
  Lines        2263     2264       +1     
==========================================
+ Hits         1719     1720       +1     
  Misses        478      478              
  Partials       66       66              
Impacted Files Coverage Δ
sso/settings.go 67.32% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59714cf...65d3980. Read the comment docs.

@synfinatic synfinatic merged commit b8b4649 into main May 7, 2022
@synfinatic synfinatic deleted the inital-setup branch May 7, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant