Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO authentication no longer uses Firefox containers #491

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

synfinatic
Copy link
Owner

Should hopefully prevent users from having to re-authenticate their SSO session needlessly.

Fixes: #486

Should hopefully prevent users from having to re-authenticate
their SSO session needlessly.

Fixes: #486
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #491 (630bce7) into main (1556ded) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   77.66%   77.70%   +0.04%     
==========================================
  Files          23       23              
  Lines        2717     2722       +5     
==========================================
+ Hits         2110     2115       +5     
  Misses        538      538              
  Partials       69       69              
Files Changed Coverage Δ
internal/url/url.go 90.57% <100.00%> (+0.31%) ⬆️
sso/awssso_auth.go 81.82% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1556ded...630bce7. Read the comment docs.

@synfinatic synfinatic merged commit 85b3a64 into main Jul 27, 2023
7 checks passed
@synfinatic synfinatic deleted the no-auth-container branch July 27, 2023 17:26
synfinatic added a commit that referenced this pull request Aug 20, 2023
This basically reverts #491 and goes back to unique Firefox
containers for each SSO provider/AWS SSO instance.  The
AuthUrlAction does allow you to pick a single SSO instance
to use your default browser via `open` to re-use the existing
session cookies you might already have.

Fixes: #524
synfinatic added a commit that referenced this pull request Aug 20, 2023
This basically reverts #491 and goes back to unique Firefox
containers for each SSO provider/AWS SSO instance.  The
AuthUrlAction does allow you to pick a single SSO instance
to use your default browser via `open` to re-use the existing
session cookies you might already have.

Fixes: #524
synfinatic added a commit that referenced this pull request Aug 20, 2023
This basically reverts #491 and goes back to unique Firefox
containers for each SSO provider/AWS SSO instance.  The
AuthUrlAction does allow you to pick a single SSO instance
to use your default browser via `open` to re-use the existing
session cookies you might already have.

Fixes: #524
synfinatic added a commit that referenced this pull request Aug 20, 2023
This basically reverts #491 and goes back to unique Firefox
containers for each SSO provider/AWS SSO instance.  The
AuthUrlAction does allow you to pick a single SSO instance
to use your default browser via `open` to re-use the existing
session cookies you might already have.

Fixes: #524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No container for SSO auth
1 participant