do not re-auth on backoff #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to sso.ListAccountRoles() can cause multiple kinds of errors: - Auth - Backoff - Others (fatal) Now we treat each kind differently and do not try to re-auth on backoff Correct documentation that `Threads` default is 5, not 10 Refs: #520
synfinatic
force-pushed
the
rate-limit
branch
3 times, most recently
from
af992df
to
2aca269
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 80.64% 80.60% -0.04%
==========================================
Files 24 24
Lines 2826 2882 +56
==========================================
+ Hits 2279 2323 +44
- Misses 477 492 +15
+ Partials 70 67 -3
Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
rate-limit
branch
2 times, most recently
from
0ced3ab
to
1302823
Compare
This seems to be probably the best- using the internal AWS SDK config options to manage our failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to sso.ListAccountRoles() can cause multiple kinds of errors:
Now we treat each kind differently and do not try to re-auth on backoff
Refs: #520