Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken ecs server stuff. Change the REST API #556

Merged
merged 6 commits into from
Aug 26, 2023
Merged

Conversation

synfinatic
Copy link
Owner

@synfinatic synfinatic commented Aug 23, 2023

Fixes: #557

@synfinatic synfinatic modified the milestones: v1.14.0, v1.13.1 Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #556 (0275b40) into main (193aa7d) will increase coverage by 1.48%.
The diff coverage is 98.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   80.84%   82.32%   +1.48%     
==========================================
  Files          25       35      +10     
  Lines        2949     3236     +287     
==========================================
+ Hits         2384     2664     +280     
- Misses        496      502       +6     
- Partials       69       70       +1     
Files Changed Coverage Δ
internal/ecs/server/httplog.go 100.00% <ø> (ø)
internal/ecs/server/logger.go 50.00% <ø> (ø)
internal/ecs/logger.go 50.00% <50.00%> (ø)
internal/ecs/client_request.go 84.21% <84.21%> (ø)
internal/ecs/http.go 100.00% <100.00%> (ø)
internal/ecs/list_profiles_response.go 100.00% <100.00%> (ø)
internal/ecs/server/default.go 100.00% <100.00%> (ø)
internal/ecs/server/profile.go 100.00% <100.00%> (ø)
internal/ecs/server/server.go 100.00% <100.00%> (ø)
internal/ecs/server/slotted.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193aa7d...0275b40. Read the comment docs.

@synfinatic synfinatic force-pushed the fix-ecs-server branch 7 times, most recently from b5b699b to 8924979 Compare August 26, 2023 17:32
@synfinatic
Copy link
Owner Author

no idea if it works.. but the tests are awesome.

@synfinatic synfinatic merged commit 410ef40 into main Aug 26, 2023
7 checks passed
@synfinatic synfinatic deleted the fix-ecs-server branch August 26, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetching ecs creds is broken in v1.13.0
1 participant