Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper functions for fish (#361) #808

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

zickzackv
Copy link
Contributor

Two fish functions as direct translations from zsh functions, trying to close #361.

Im using fish version 3.7.1 and assume that the subcommand syntax in aws-sso-clear ($(command)) needs atleast fish version > 3.0.0.

Copy link
Owner

@synfinatic synfinatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. thanks for the PR!

set --local _args (string split -- ' ' $AWS_SSO_HELPER_ARGS)
set -q AWS_SSO_HELPER_ARGS; or set --local _args -L error
if [ -z "$AWS_PROFILE" ]
echo "AWS_PROFILE ist not set"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spelling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@synfinatic synfinatic merged commit 45898a6 into synfinatic:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fish support for aws-sso-profile
2 participants