Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS_CONTAINER_AUTHORIZATION_TOKEN support #916

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

synfinatic
Copy link
Owner

fixes: #516

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (3f23df2) to head (046b0b6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   83.07%   83.29%   +0.22%     
==========================================
  Files          38       40       +2     
  Lines        2741     2825      +84     
==========================================
+ Hits         2277     2353      +76     
- Misses        379      384       +5     
- Partials       85       88       +3     
Flag Coverage Δ
unittests 83.29% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.50% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f23df2...046b0b6. Read the comment docs.

@synfinatic synfinatic force-pushed the ecs-security-token branch 6 times, most recently from eb7d138 to 551d840 Compare June 27, 2024 20:07
- remove -race flag from unit tests since it was generating warnings

fixes: #516
@synfinatic synfinatic merged commit 43ba585 into main Jun 27, 2024
7 checks passed
@synfinatic synfinatic deleted the ecs-security-token branch June 27, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support AWS_CONTAINER_AUTHORIZATION_TOKEN
1 participant