Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedbuilder tool #58

Closed
wants to merge 21 commits into from
Closed

Fix feedbuilder tool #58

wants to merge 21 commits into from

Conversation

vbjay
Copy link

@vbjay vbjay commented Oct 10, 2015

Ignoring files only worked on files in the root folder. All subdirectory files did not remember the ignored files in the tool.

@vbjay
Copy link
Author

vbjay commented Oct 12, 2015

Ready to pull.
I do have one question. 89505f4 upgrades to 4.5. Should it be 4.0? What are your thoughts @synhershko
Summary of changes:

  • Fix ignore issue in feedbuilder
  • Make feedbuilder process files in the background

@synhershko
Copy link
Owner

Thanks @vbjay. The changes to FeedBuilder look good and the rest look like just whitespace and an f/w version update.

The framework version of FeedBuilder doesn't really matter, it's a tool and you should probably have the latest version of the framework installed anyway. However, that isn't the case for the target platforms - the one you are trying to run an update process on. Can you please avoid compiling NAU for 4.0 and leave it 2.0? last time I was working on this I made sure there isn't anything important NAU is missing by using 2.0, I believe that still is the case.

@vbjay
Copy link
Author

vbjay commented Oct 16, 2015

OK. I will revert the changes to the framework version to the library
projects later on today.

On Fri, Oct 16, 2015, 6:17 AM Itamar Syn-Hershko notifications@github.com
wrote:

Thanks @vbjay https://github.com/vbjay. The changes to FeedBuilder look
good and the rest look like just whitespace and an f/w version update.

The framework version of FeedBuilder doesn't really matter, it's a tool
and you should probably have the latest version of the framework installed
anyway. However, that isn't the case for the target platforms - the one you
are trying to run an update process on. Can you please avoid compiling NAU
for 4.0 and leave it 2.0? last time I was working on this I made sure there
isn't anything important NAU is missing by using 2.0, I believe that still
is the case.


Reply to this email directly or view it on GitHub
#58 (comment).

@robinwassen
Copy link
Collaborator

@synhershko - May I take care of merging these changes?

@synhershko
Copy link
Owner

Sure, go ahead

@vbjay
Copy link
Author

vbjay commented Dec 3, 2016

Looking to rebase this. Trying not to code stomp.

@vbjay
Copy link
Author

vbjay commented May 26, 2017

Reworking with new branch

@vbjay vbjay closed this May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants