Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpdateTask serialize/deserialize mismatch: version field is absent #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FileUpdateTask serialize/deserialize mismatch: version field is absent #119

wants to merge 1 commit into from

Conversation

firsinanton
Copy link

No description provided.

@synhershko
Copy link
Owner

Why do you need Version in a FileUpdateTask?

@firsinanton
Copy link
Author

firsinanton commented Feb 28, 2018 •
edited

Why do you need Version in a FileUpdateTask?

For example, for logging.
In my case it is not so necessary, but "version" attribute exists in xml, it appears there while serialization (FeedBuilder\frmMain.cs: 308):
<FileUpdateTask localPath="AlphaFS.dll" lastModified="130677864340000000" fileSize="270336" version="2.0.1.0">

I think this is mismatch, that in one side "version" attribute is serialized, in other does not deserialized.
Probably, it would be better to use XmlSerializer class for this purpose to avoid same mismatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@firsinanton @synhershko