Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some issues encountered with a German locale #5

Merged
merged 1 commit into from Feb 6, 2013

Conversation

e-tobi
Copy link

@e-tobi e-tobi commented Dec 11, 2012

No description provided.

@dsmiley
Copy link

dsmiley commented Dec 11, 2012

Um, I intended for Spatial4j / Spatial4n is supposed to be locale-independent -- i.e. toString() should be the same no matter what your locale is. But I suppose, given that this toString() representation is purely for debugging purposes and is not an official representation of the shape, that this could be relaxed here?

@e-tobi
Copy link
Author

e-tobi commented Dec 11, 2012

I think ToString() should by default output a human readable string which should be formatted for the users culture.

@synhershko
Copy link
Owner

Blah, stupid github notifications

This change is actually going your way, David - its mainly a forgotten CultureInfo.InvariantCulture in ReadStandardShape

synhershko added a commit that referenced this pull request Feb 6, 2013
Fixing some issues encountered with a German locale
@synhershko synhershko merged commit deac636 into synhershko:master Feb 6, 2013
@synhershko
Copy link
Owner

Thanks Tobi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants