Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge to dev #20

Merged
merged 8 commits into from
Aug 6, 2022
Merged

merge to dev #20

merged 8 commits into from
Aug 6, 2022

Conversation

synodriver
Copy link
Owner

No description provided.

@synodriver synodriver merged commit c8c34b3 into dev Aug 6, 2022
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 6, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.98%.

Quality metrics Before After Change
Complexity 2.17 ⭐ 2.23 ⭐ 0.06 👎
Method Length 30.94 ⭐ 36.34 ⭐ 5.40 👎
Working memory 5.07 ⭐ 5.65 ⭐ 0.58 👎
Quality 86.54% 83.56% -2.98% 👎
Other metrics Before After Change
Lines 1238 1385 147
Changed files Quality Before Quality After Quality Change
setup.py 93.13% ⭐ 93.09% ⭐ -0.04% 👎
aioaria2/init.py 87.34% ⭐ 85.61% ⭐ -1.73% 👎
aioaria2/client.py 83.91% ⭐ 83.81% ⭐ -0.10% 👎
aioaria2/exceptions.py 93.98% ⭐ 93.09% ⭐ -0.89% 👎
aioaria2/parser.py 67.77% 🙂
aioaria2/server.py 93.96% ⭐ 94.38% ⭐ 0.42% 👍
aioaria2/utils.py 84.57% ⭐ 84.90% ⭐ 0.33% 👍
tests/test_parser.py 89.48% ⭐
tests/test_server.py 95.61% ⭐ 95.64% ⭐ 0.03% 👍
tests/test_websocket.py 90.41% ⭐ 90.23% ⭐ -0.18% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
aioaria2/parser.py ControlFile.from_reader 8 ⭐ 211 ⛔ 16 ⛔ 40.76% 😞 Try splitting into smaller methods. Extract out complex expressions
aioaria2/client.py Aria2WebsocketTrigger.__init__ 4 ⭐ 142 😞 16 ⛔ 50.81% 🙂 Try splitting into smaller methods. Extract out complex expressions
aioaria2/client.py _Aria2BaseClient.jsonrpc 15 🙂 130 😞 10 😞 51.10% 🙂 Try splitting into smaller methods. Extract out complex expressions
aioaria2/parser.py ControlFile.save 8 ⭐ 192 😞 6 ⭐ 60.26% 🙂 Try splitting into smaller methods
aioaria2/client.py Aria2WebsocketTrigger.new 1 ⭐ 104 🙂 14 😞 60.85% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant