Dev (Sourcery refactored) #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/dev
branch
from
bbadac2
to
a58de82
Compare
| if self.mode == "format": | ||
| return req_obj | ||
| return await self.send_request(req_obj) | ||
| return req_obj if self.mode == "format" else await self.send_request(req_obj) |
There was a problem hiding this comment.
Function _Aria2BaseClient.jsonrpc refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-120
to
+118
| results = await asyncio.gather(*map(self.send_request, req_objs)) | ||
| return results | ||
| return await asyncio.gather(*map(self.send_request, req_objs)) |
There was a problem hiding this comment.
Function _Aria2BaseClient.process_queue refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-735
to
+732
| for gid in gids: | ||
| for _ in gids: |
There was a problem hiding this comment.
Function _Aria2BaseClient.get_statuses refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| for line in f.readlines(): | ||
| for line in f: |
There was a problem hiding this comment.
Function read_configfile refactored with the following changes:
- Iterate over files directly rather than using readlines() (
use-file-iterator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #25 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
devbranch, then run:Help us improve this pull request!