fix: keep maintenance file alive when maintenance mode is disabled #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxperei
force-pushed
the
bugfix/disable-maintenance-file-without-removing-it
branch
2 times, most recently
from
913d914
to
28a2517
Compare
oallain
reviewed
Dec 1, 2023
There was a problem hiding this comment.
@maxperei Can you add a littre word about thas in the doc in https://github.com/synolia/SyliusMaintenancePlugin#you-can-turn-your-website-under-maintenance-by-console-commands- ?
|
could you please fix CI on branch master @oallain 🙏 |
maxperei
force-pushed
the
bugfix/disable-maintenance-file-without-removing-it
branch
from
c0a5e18
to
d85b5d8
Compare
…ionally removable tho; resolves #35
oallain
force-pushed
the
bugfix/disable-maintenance-file-without-removing-it
branch
from
d85b5d8
to
59981d4
Compare
oallain
approved these changes
Dec 18, 2023
maxperei
deleted the
bugfix/disable-maintenance-file-without-removing-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing maintenance file is still possible but now optional just run
bin/console maintenance:disable [-c|--clear]