Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Fix Support Link #1102

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(settings): Fix Support Link #1102

merged 1 commit into from
Jun 6, 2023

Conversation

coreyphillips
Copy link
Collaborator

Description

  • Adds fallback url to the support link.
  • Adds encodeURIComponent to subject and body in createSupportLink method.

Linked Issues/Tasks

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

  • No test

QA Notes

  • Navigate to Settings->About Bitkit and tap Support on a live iOS/Android device.
    • Expected: Bitkit should either open the device's default mail client, open a drawer to select and open a mail client or fallback to use the synonym.to support page in the event a default mail client is not available on the device.

@coreyphillips
fix(settings): Fix Support Link
71e66b9 
Adds fallback url to the support link.
Adds encodeURIComponent to subject and body in createSupportLink method.
This fixes #1095
@coreyphillips coreyphillips requested a review from pwltr June 6, 2023 10:14
@coreyphillips coreyphillips mentioned this pull request Jun 6, 2023
Closed
bonomat
bonomat approved these changes Jun 6, 2023
View reviewed changes
Copy link

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast fix.

@coreyphillips coreyphillips merged commit 667cc8f into master Jun 6, 2023
4 checks passed
@coreyphillips coreyphillips deleted the support-link-fix branch June 6, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

@bonomat bonomat bonomat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Support button not working
3 participants
@coreyphillips @bonomat @pwltr