Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightning): sync ldk fees when refreshing #1113

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix(lightning): sync ldk fees when refreshing #1113

merged 1 commit into from
Jun 21, 2023

Conversation

Jasonvdb
Copy link
Collaborator

Description

Syncs LDK fees when refreshing. Refresh function is called right before closing a channel so this could avoid any potential fee mismatching with counter party node resulting in a force close.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

We should see less force closing channels.

@Jasonvdb Jasonvdb requested a review from pwltr June 15, 2023 11:35
@pwltr pwltr merged commit d2d50dc into master Jun 21, 2023
4 checks passed
@pwltr pwltr deleted the sync-fees branch June 21, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants