feat(lang): change locale format to ICU #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
force-pushed
the
icu
branch
2 times, most recently
from
6539f8e
to
1bb569a
Compare
pwltr
requested changes
Jun 21, 2023
pwltr
requested changes
Jun 21, 2023
pwltr
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Transifex doesn't support i18next native file format.
Solution: Use ICU file format for language files
Which causes another problem: it is not expandable, we can't use cool i18next formatters like date or relative time
Solution: add another instance of i18next to format dates and relative time.
ICU file format uses single brackets instead of double, so I'me updating all language file.
Type of change
Refactoring
Tests
No test