Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI fixes #1135

Merged
merged 5 commits into from
Jun 29, 2023
Merged

fix: UI fixes #1135

merged 5 commits into from
Jun 29, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jun 28, 2023

Description

  • make sure 'clipboard ease-of-use' redirect is only offered after AuthCheck
  • fix list item touchable opacity
  • Send: fix the loading state after auth (w/ PIN for payments enabled)
  • Activity: pass activityItem directly to notification to make sure there is no rerender or empty notification
  • chore: add env var to ignrore LDK logs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

  1. enable clipboard ease-of-use
  • app start / normal -> no redirect
  • app start / with deep link -> should redirect
  • app start / with clipboard data -> should offer redirect
  • app to foreground / normal -> no redirect
  • app to foreground / with deep link -> should redirect
  • app to foreground / with clipboard data -> should offer redirect
  1. enable PIN on launch & PIN when idle
  • app start w/ pinOnLaunch / normal -> should show PIN check
  • app start w/ pinOnLaunch / with deep link -> should show PIN check and redirect
  • app start w/ pinOnLaunch / with clipboard data -> should show PIN check and offer redirect
  • app to foreground w/ pinOnIdle / normal -> should show PIN check
  • app to foreground w/ pinOnIdle / with deep link -> should show PIN check and redirect
  • app to foreground w/ pinOnIdle / with clipboard data -> should show PIN check and offer redirect

@pwltr pwltr changed the title Fix/UI fixes fix: UI fixes Jun 28, 2023
@pwltr pwltr requested a review from limpbrains June 28, 2023 14:24
@pwltr pwltr merged commit 690aef1 into master Jun 29, 2023
4 checks passed
@pwltr pwltr deleted the fix/ui-fixes branch June 29, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants