Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): fix export logs #1380

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix(settings): fix export logs #1380

merged 2 commits into from
Nov 15, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 14, 2023 •
edited
Loading

Description

Fixes missing logs for LDK account v2 in recovery mode and adds a menu item to export logs including sensitive .bin files in DevSettings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr merged commit 78ae365 into master Nov 15, 2023
4 checks passed
@pwltr pwltr deleted the fix/recovery-logs branch November 15, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

@Jasonvdb Jasonvdb Awaiting requested review from Jasonvdb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pwltr @coreyphillips