Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor contact add #1381

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: refactor contact add #1381

merged 1 commit into from
Nov 29, 2023

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented Nov 16, 2023

Description

  • upgrade synonymdev/slashtags-url
  • refactor contact add form so that user can type slash url + relay

Linked Issues/Tasks

Type of change

Bug fix

Tests

Detox test

@limpbrains limpbrains changed the title fix: upgrade @synonymdev/slashtags-url fix: refactor contact add Nov 16, 2023
@pwltr
Copy link
Collaborator

pwltr commented Nov 28, 2023

Couple of findings:

  • In the design the text has the brand color on error state

image

  • The field is overlaying the button when a valid url is passed

Simulator Screenshot - iPhone 15 - 2023-11-28 at 18 19 59

  • There is a slight layout shift when the error message appears
  • I think the paste button shouldn't require pressing 'Add' again if the url was valid
  • The position for the error text is a bit suboptimal when it comes to multi-lang support. Quickly tested german text and it wouldn't fit in one row together with the label on the left.

@limpbrains
Copy link
Collaborator Author

In the design the text has the brand color on error state
The field is overlaying the button when a valid url is passed
There is a slight layout shift when the error message appears
I think the paste button shouldn't require pressing 'Add' again if the url was valid

fixed

The position for the error text is a bit suboptimal when it comes to multi-lang support. Quickly tested german text and it wouldn't fit in one row together with the label on the left.

Agree. I've added text wrap. Now if error message doesn't fit, it will appear on the new line

@limpbrains limpbrains merged commit 70b747c into master Nov 29, 2023
3 of 4 checks passed
@limpbrains limpbrains deleted the url branch November 29, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants