refactor: use react-native-quick-crypto, remove rn-nodify #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
requested changes
Nov 28, 2023
limpbrains
reviewed
Nov 28, 2023
ios/Podfile.lock
Outdated
Comment on lines
79
to
81
| - MMKV (1.3.1): | ||
| - MMKVCore (~> 1.3.1) | ||
| - MMKVCore (1.3.1) | ||
| - MMKV (1.3.0): | ||
| - MMKVCore (~> 1.3.0) | ||
| - MMKVCore (1.3.0) |
There was a problem hiding this comment.
I'm qurious why MMKV version changed? I don't have it on my local maching when I do pod install maybe you should try pod install --repo-update ?
There was a problem hiding this comment.
done, but now it updated it to newer versions. Not sure why it always downgrades some packages on my machine.
pwltr
force-pushed
the
rn-quick-crypto
branch
2 times, most recently
from
ccc8705
to
6e360e8
Compare
limpbrains
approved these changes
Nov 28, 2023
coreyphillips
approved these changes
Dec 11, 2023
pwltr
force-pushed
the
rn-quick-crypto
branch
from
6e360e8
to
ab3a962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
cryptocalls withreact-native-quick-cryptowhich should offer way better performance since it's using JSI/C++. Allows us to removern-nodifyand for Node core module polyfilling. Also replacestext-encodingwith faster alternativefastestsmallesttextencoderdecoder. Renames.node-versionfile so it can be picked up by version managers.Type of change
Tests
QA Notes
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce during the Bitkit testing session. You can also leave a video of the PR in action.