fix(lightning): update transfer to spending flow #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
fix/ln-onboarding
branch
3 times, most recently
from
a883c51
to
47b221c
Compare
coreyphillips
approved these changes
Jan 16, 2024
pwltr
force-pushed
the
fix/ln-onboarding
branch
2 times, most recently
from
2800a85
to
97f8209
Compare
pwltr
force-pushed
the
fix/ln-onboarding
branch
from
97f8209
to
77b0588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes transfer to spending (onchain channel orders) flow to allow turbo channels again since BT changed policy and shows correct wait times.
Related: https://github.com/synonymdev/blocktank-lsp-http/pull/70
Notes
Large diff in
yarn.lockdue to added peer dependencyblocktank-lsp-btc. I checked withreact-native-bundle-visualizer(also added in this PR) and none of it seems to end up in the bundle so find but probably BT client lib should be cleaned up a bit.Type of change
Tests
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-15.at.18.04.10.mp4
QA Notes
Tested QuickSetup, CustomSetup, Transfer
CustomSetup with 0 local balance still opens channel immediately, with local balance takes 1 confirmation (10minutes)