Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onboarding text layout #1858

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: onboarding text layout #1858

merged 1 commit into from
May 23, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented May 22, 2024

Description

  • Do not limit text width
  • if Arrow can't fit, move it below the text
  • move line breaking logic to language file
  • also fixes missing nav title

Linked Issues/Tasks

closes #1840
closes #1859

Type of change

Bug fix

Tests

No test

Screenshot / Video

@limpbrains limpbrains marked this pull request as ready for review May 22, 2024 12:27
@limpbrains limpbrains requested a review from pwltr May 22, 2024 12:27
src/utils/i18n/locales/en/onboarding.json Outdated Show resolved Hide resolved
src/screens/Lightning/Success.tsx Outdated Show resolved Hide resolved
src/components/WalletOnboarding.tsx Outdated Show resolved Hide resolved
@limpbrains limpbrains requested a review from pwltr May 23, 2024 12:00
@limpbrains limpbrains merged commit 0eb32fa into master May 23, 2024
6 checks passed
@limpbrains limpbrains deleted the onboarding-text branch May 23, 2024 12:05
@catch-21
Copy link
Contributor

Tested on v118
Mostly LGTM, although I did see the arrow behind text for Russian so we probably should hide to when text is wider: #1895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants