Introducing Runtime Packages #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without SynFPCLinux and SynFPCSock, SynCommons and SynCrtSock won't compile on Linux. |
|
SynCommons was included on mormot_base package. |
- introduced a macro package to find the place of Zeos.inc
|
This a3a4197 fixes item 3. |
|
@synopse do I need to do more improvements to merge? Please, let me know. |
synopse
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments:
mormot_zeos- see item 3.SynFPCCMemAligned,SynFPCLinux,SynFPCSockonmormot_base, as these files are platform (Linux vs Windows) dependent.SynDBZeosuses{$I Zeos.inc}but this file do not have direct access to this inc file without a hard-coded path. I don't know how to solve this yet.