Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynDBOracle - fix removing of ending semicolon #369

Merged
merged 1 commit into from
Dec 11, 2020
Merged

SynDBOracle - fix removing of ending semicolon #369

merged 1 commit into from
Dec 11, 2020

Conversation

pavelmash
Copy link
Sponsor Collaborator

@pavelmash pavelmash commented Dec 11, 2020 •
edited

fix removing of ending semicolon for statements ends with END what is part of an identifier, like

ALTER TABLE BLA_BLA DROP COLUMN STR_PREPEND;

or

SELECT SOMETHING FROM PERIODICALEND;

pavelmash pushed a commit that referenced this pull request Dec 11, 2020
merge #369 into SyNodeCleanup
c8f7b7a
synopse
synopse approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@synopse synopse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky but if it works....

@synopse synopse merged commit 58df361 into master Dec 11, 2020
synopse pushed a commit to synopse/mORMot2 that referenced this pull request Dec 11, 2020
SynDBOracle - fix removing of ending semicolon
bb61534 
- from synopse/mORMot#369
@pavelmash pavelmash deleted the fix/OraTrailingSemicolon branch January 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synopse synopse synopse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavelmash @synopse