New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix surrogates in RawUnicodeToUtf8 for FPC #90

Merged

synopse merged 1 commit into master from fix/utf8SurrogatesForFPC

Mar 1, 2018

Sponsor Collaborator

pavelmash commented Mar 1, 2018

Test case is string with broken surrogate pair 'ab\ud800cd'
FPC compiler (x64) evaluated condition

cardinal(Source^)-UTF16_LOSURROGATE_MIN>UTF16_LOSURROGATE_MAX-UTF16_LOSURROGATE_MIN

to false, Delphi - to true.
Condition replaced by more compiler (and human) friendly


          fix surrogates in RawUnicodeToUtf8 for FPC

de3e8b1

Sponsor Collaborator Author

pavelmash commented Mar 1, 2018

Will be good to add a test case to SynSelfTests.pas for this....

synopse merged commit 462fddd into master

pavelmash deleted the fix/utf8SurrogatesForFPC branch

March 1, 2018 09:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment