introducing cross-platform INVALID_HANDLE_VALUE constant

src/core/mormot.core.os.pas

@@ -2631,6 +2631,9 @@ function FileTimeToUnixMSTime(const FT: TFileTime): TUnixMSTime;
 {$else}
 
 const
+  /// a cross-platform incorrect THandle value, as defined in Windows unit
+  INVALID_HANDLE_VALUE = THandle(-1);
+
   /// allow to assign proper signed symbol table name for a libc.so.6 method
   {$ifdef OSLINUXX64}
   LIBC_SUFFIX = '@GLIBC_2.2.5';
@@ -4338,6 +4341,7 @@   TAutoLock = class(TInterfacedObject)
   end;
 
   /// our lightweight cross-platform TEvent-like component
+  // - on Windows, calls directly the CreateEvent/ResetEvent/SetEvent API
   // - on Linux, will use eventfd() in blocking and non-semaphore mode
   // - on other POSIX, will use PRTLEvent which is lighter than TEvent BasicEvent
   // - only limitation is that we don't know if WaitFor is signaled or timeout,

src/core/mormot.core.os.windows.inc

@@ -958,7 +958,7 @@ begin
    result := CreateFileW(W32(aFileName, tmp), ACCESS[aMode and 3], SHARE[s],
      nil, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0)
   else
-    result := THandle(-1);
+    result := INVALID_HANDLE_VALUE;
 end;
 
 function FileSetDateFrom(const Dest: TFileName; SourceHandle: THandle): boolean;
@@ -3267,11 +3267,11 @@ begin
       exit;
     add := address;
     virt := nil;
-    if NtMapViewOfSection(mem, THandle(-1), @virt, 0, size, add, @size,
+    if NtMapViewOfSection(mem, INVALID_HANDLE_VALUE, @virt, 0, size, add, @size,
          1, 0, PAGE_READONLY) = 0 then
     begin
       FastSetRawByteString(result, virt, size);
-      NtUnmapViewOfSection(THandle(-1), virt);
+      NtUnmapViewOfSection(INVALID_HANDLE_VALUE, virt);
     end;
     CloseHandle(mem);
   end;

src/mormot.commit.inc

@@ -1 +1 @@
-'2.1.5806'
+'2.1.5807'

src/net/mormot.net.sock.pas

@@ -4696,7 +4696,7 @@ procedure TCrtSocket.CreateSockIn(LineBreak: TTextLineBreakStyle;
     BufSize := InputBufferSize;
     BufPtr := pointer(PAnsiChar(SockIn) + SizeOf(TTextRec));
     OpenFunc := @OpenSock;
-    Handle := {$ifdef FPC}THandle{$endif}(0); // some invalid handle
+    Handle := INVALID_HANDLE_VALUE;
   end;
   SetLineBreakStyle(SockIn^, LineBreak); // http does break lines with #13#10
   Reset(SockIn^);
@@ -4718,7 +4718,7 @@ procedure TCrtSocket.CreateSockOut(OutputBufferSize: integer);
     BufSize := OutputBufferSize;
     BufPtr := pointer(PAnsiChar(SockIn) + SizeOf(TTextRec)); // ignore Buffer[] (Delphi 2009+)
     OpenFunc := @OpenSock;
-    Handle := {$ifdef FPC}THandle{$endif}(0);
+    Handle := INVALID_HANDLE_VALUE;
   end;
   SetLineBreakStyle(SockOut^, tlbsCRLF); // force e.g. for Linux platforms
   Rewrite(SockOut^);