Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the declare of table_column_metadata is wrong #84

Closed
mksjgj opened this issue Apr 12, 2022 · 2 comments
Closed

the declare of table_column_metadata is wrong #84

mksjgj opened this issue Apr 12, 2022 · 2 comments

Comments

@mksjgj
Copy link

mksjgj commented Apr 12, 2022

the declare of table_column_metadata in mORMot 2 is:
table_column_metadata: function(DB: TSqlite3DB; zDbName, zTableName,
zColumnName: PUtf8Char; var pzDataType, pzCollSeq: PUtf8Char;
var pNotNull, pPrimaryKey, pAutoinc: PInteger): integer; cdecl;

i think: var pNotNull, pPrimaryKey, pAutoinc: PInteger
should be: out pNotNull, pPrimaryKey, pAutoinc: Integer,

i had checked with System.Sqlite.pas in Delphi 10.3.3

synopse pushed a commit that referenced this issue Apr 12, 2022
@synopse
Copy link
Owner

synopse commented Apr 12, 2022

Should be fixed now.

Thanks for the report.

@synopse
Copy link
Owner

synopse commented Apr 19, 2022

I guess it is fine now with the last week commit.
Please reopen on issue.

@synopse synopse closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants