Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to copy c_src dir to my own project, can I have the permit? #45

Closed
falood opened this issue Apr 8, 2017 · 4 comments
Closed

Comments

@falood
Copy link
Contributor

falood commented Apr 8, 2017

Hi @5HT

I think you know I have an elixir project to do a wrapper of fs called exfswatch, thank you very much for your work!
But I alway get errors when fs release new versions and it's hard to do compatible, so I want to copy c_src folder and priv/inotifywait.exe to my own repo and rewrite some codes from erlang to elixir.

can I do this? and what else should I do if do it? I declare my project based on fs in readme file and package description, is there any other declaration should I have?
here is the pull request https://github.com/falood/exfswatch/pull/18/files

Thanks ❤️

@5HT
Copy link
Owner

5HT commented Apr 8, 2017

Sure! Please do the fork so I can remove bullshit binaries from my project!
And break the compatibility with Elixir forever!
No mentions of us as the authors are required. But if you are willing — we don't mind.

cc @josevalim @proger

@falood
Copy link
Contributor Author

falood commented Apr 8, 2017

Thank you very much!
I have to give a general API except the DSL if you no longer want to support elixir, will let you know when I'm ready.

@5HT
Copy link
Owner

5HT commented Apr 9, 2017

Anyway I will wait for exfswatch to become globally available and fully integrated into phoenix live reloader. Please notify me when I can perform the breaking changes.

@falood
Copy link
Contributor Author

falood commented Oct 11, 2017

I think we can close this issue now 🙂 Thanks

@falood falood closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants