-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to update the grid when 2D brushing is applied? #74
Comments
Try using brushend in stead of brush. Currently the 2D brush doesn’t emit a brush on each change. This is to avoid costly calculations. |
@bbroeksema Thanks, but when I use this function, |
@TharinduDR First of all: does that actually update the table for you when brushing? That is, does the table content reflect the brushed items once you have finished placing a strum? (This would mean we at least solved part of the problem). Secondly, I'm not sure if I understand correctly from the pictures what your problem is. Is it the case that when you remove a strum, the pcp still only shows the items that where brushed when the strum was still there? The pictures do look different to me. Thirdly: can you try two things (one at a time):
try:
in your copy of d3.parcoords.js? Let me know if this solves your problem. If not, I'd have to look into it, but for that I would need a minimal example showing the issue. |
@bbroeksema Thank you very much for the quick reply. When I changed brushend instead of brushed, table content reflected the brushed items once I have finished placing a strum.(Yes so we have solved a part of the problem)
I use these functions, function gridUpdate(data) an error throws from dataView.endUpdate(); when I remove the strum. |
@TharinduDR which error is thrown from datView.endUpdate()? It seems to be an event handling issue. Did you follow/use one of the examples as the basis for your application? I guess, the slickgrid one. I'll check tomorrow if i can reproduce it. |
Yeah I have used the slickgrid example as it is. The only change I did was to change the brushMode to "2D-strums". function endUpdate() { |
I'll try to reproduce it, hopefully this weekend. But I'm a bit short on time so, be patient. Of course, if you figure out yourself where the error comes, from in the meantime.... I'd be more than happy to merge the fixes. |
@bbroeksema Sure. Thank you very much. |
@TharinduDR I tested with above changes to example slickgrid and it worked for me with 711a115. Can you test if this solves the problem for you as well? If it doesn't feel free to reopen. |
@bbroeksema Thank you very much it is working now |
Is there a way to update the grid when the 2D brushing is used? right now I am using this method to update the grid, but it doesn't work for 2D brushing, it works only for 1D brushing.
parcoords.on("brush", function(d) {
gridUpdate(d);
});
The text was updated successfully, but these errors were encountered: