Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally allow for SSL #4

Merged
merged 11 commits into from
Jan 17, 2019
Merged

Optionally allow for SSL #4

merged 11 commits into from
Jan 17, 2019

Conversation

syntaqx
Copy link
Owner

@syntaqx syntaqx commented Jan 17, 2019

Feature request from reddit:

Original Comment
Author: qu33ksilver

This is a simple tool. Let's keep it simple. For my local development, I use http-server. I would want serve to be like that.

Pass ssl certs and keys through a flag, enable https. Done. Why does port become tricky ?

This tool is for local development. I should be just able to create certs using mkcert and pass them to > this tool. Do not do any magic under the hoods.

Ignore letsencrypt.

No need to redirect. Enable https if flag is set. Otherwise http. Don't overdo things.

If you want others to import this, then sure, go ahead and expose server. But I think that is not needed.

Still a work in progress.

@syntaqx syntaqx added the enhancement New feature or request label Jan 17, 2019
@syntaqx syntaqx self-assigned this Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
Repository owner deleted a comment from codecov bot Jan 17, 2019
@syntaqx syntaqx changed the title [WIP] Optionally allow for SSL Optionally allow for SSL Jan 17, 2019
@syntaqx syntaqx merged commit 6e5e397 into master Jan 17, 2019
@syntaqx syntaqx deleted the feature/ssl branch January 17, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant