Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): add vfile-message #4

Merged
merged 1 commit into from
May 4, 2023

Conversation

tknickman
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fixes transitive dependency on vfile-message - this was causing issues when using this package with pnpm (depending on your hoist settings).

vfile-message is referenced here: https://github.com/syntax-tree/hast-util-from-html/blob/main/lib/index.js#L64, despite it not being included as a dependency here: https://github.com/syntax-tree/hast-util-from-html/blob/main/package.json#L35-L40.

This is working in most cases currently as hast-util-from-html does depend on vfile: https://github.com/syntax-tree/hast-util-from-html/blob/main/package.json#L39, and vfile depends on vfile-message: https://github.com/vfile/vfile/blob/main/package.json#L57, allowing the dependency to be referenced transitively (unless using a package manager like pnpm which supports isolating modules to prevent this issue)

I discovered this when updating nextra on turbo.build:

nextra
├─┬ rehype-katex 6.0.2
│ ├─┬ rehype-parse 8.0.4
│ │ ├─┬ hast-util-from-parse5 7.1.0
│ │ │ ├─┬ vfile 5.3.4
│ │ │ │ └── vfile-message 3.1.2

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 3, 2023
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@wooorm wooorm merged commit b5ac23e into syntax-tree:main May 4, 2023
3 checks passed
@github-actions

This comment has been minimized.

@wooorm wooorm added 📦 area/deps This affects dependencies 💪 phase/solved Post is done labels May 4, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label May 4, 2023
@wooorm
Copy link
Member

wooorm commented May 4, 2023

Thank you, released in 1.0.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants