Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions #10

Merged
merged 5 commits into from
May 21, 2020
Merged

Add TypeScript definitions #10

merged 5 commits into from
May 21, 2020

Conversation

remcohaszing
Copy link
Member

@remcohaszing remcohaszing commented May 9, 2020

Because of reasoning in unifiedjs/unified#45, all packages consuming these types need to add dependencies on @types/node, @types/parse5, and unified.

It’s now applied on the entire workspace. All HTML and markdown files are
ignored.
@ChristianMurphy ChristianMurphy requested a review from a team May 9, 2020 13:35
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels May 9, 2020
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remcohaszing!

package.json Outdated Show resolved Hide resolved
@remcohaszing
Copy link
Member Author

The build appears to be green, but Travis didn’t report the status to GitHub 🤔

@ChristianMurphy
Copy link
Member

The build appears to be green, but Travis didn’t report the status to GitHub 🤔

Travis CI does that sometimes 😞
Closing and reopening the PR refreshes the build and status checks. ♻️

@wooorm wooorm merged commit aa17c1a into syntax-tree:master May 21, 2020
@wooorm
Copy link
Member

wooorm commented May 21, 2020

Released in 6.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

None yet

3 participants