Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to parse5@7 #17

Merged
merged 3 commits into from Jan 15, 2023
Merged

Update to parse5@7 #17

merged 3 commits into from Jan 15, 2023

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Oct 27, 2022

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

parse5 received a rather big update in v7.
This commit rewrites basically everything, to work with that.

@wooorm wooorm added 🧑 semver/major This is a change 👍 phase/yes Post is accepted and can be worked on labels Oct 27, 2022
@github-actions

This comment has been minimized.

Sign in to view
@wooorm
Copy link
Member Author

wooorm commented Oct 27, 2022

Oh this also needs a release of hast-util-{from,to}-parse5

@wooorm wooorm marked this pull request as draft October 27, 2022 14:01
@wooorm
Update for parse5@7
6ce1046 
`parse5` received a rather big update in v7.
This commit rewrites basically everything, to work with that.
@wooorm
Remove ts-expect-error
1453690
@wooorm wooorm mentioned this pull request Dec 23, 2022
Closed
4 tasks
@wooorm wooorm marked this pull request as ready for review January 15, 2023 14:59
@wooorm wooorm changed the title Update for parse5@7 Update to parse5@7 Jan 15, 2023
@wooorm wooorm merged commit 5414bb6 into main Jan 15, 2023
@wooorm wooorm deleted the parse5-7 branch January 15, 2023 16:09
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 15, 2023
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Jan 15, 2023
@Methuselah96 Methuselah96 mentioned this pull request Aug 28, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💪 phase/solved Post is done 🧑 semver/major This is a change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wooorm