Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use module augmentation instead of @ts-expect-error #5

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This removes the need for some @ts-expect-error comments.

@remcohaszing remcohaszing added 🏡 area/internal This affects the hidden internals ☂️ area/types This affects typings 🤞 phase/open Post is being triaged manually labels Feb 15, 2024
This removes the need for some `@ts-expect-error` comments.
@wooorm
Copy link
Member

wooorm commented Feb 19, 2024

I don’t think that “mocking” the react types is better than a @ts-expect-error but fine if you want this

@wooorm wooorm changed the title Use module augmentation to define missing types Refactor to use module augmentation instead of @ts-expect-error Feb 19, 2024
@wooorm wooorm merged commit 5ae98d2 into main Feb 19, 2024
4 checks passed
@wooorm wooorm deleted the augment-untyped-modules branch February 19, 2024 09:56
@wooorm wooorm added the 💪 phase/solved Post is done label Feb 19, 2024

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals ☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants