Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix roundtripping attention-like underscores #43

Merged
merged 2 commits into from Sep 18, 2021
Merged

Fix roundtripping attention-like underscores #43

merged 2 commits into from Sep 18, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Sep 16, 2021

Related to GH-25.

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This solves roundtripping underscores by escaping all of them (same as for asterisks).

@wooorm wooorm linked an issue Sep 16, 2021 that may be closed by this pull request
Roundtripping list in list, with paragraph in top list, causes paragraph to disappear #42
Closed
4 tasks
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Sep 16, 2021
@wooorm wooorm linked an issue Sep 16, 2021 that may be closed by this pull request
Roundtripping emphasis like plain text results in emphasis #25
Closed
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 16, 2021
@wooorm wooorm mentioned this pull request Sep 16, 2021
Closed
@wooorm wooorm added the 🙆 yes/confirmed This is confirmed and ready to be worked on label Sep 16, 2021
@github-actions github-actions bot added 👍 phase/yes Post is accepted and can be worked on and removed 🤞 phase/open Post is being triaged manually labels Sep 16, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface labels Sep 16, 2021
@wooorm wooorm merged commit fce3057 into main Sep 18, 2021
@wooorm wooorm deleted the attention-like-text branch September 18, 2021 08:20
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 18, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on 🙆 yes/confirmed This is confirmed and ready to be worked on labels Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
1 participant
@wooorm