Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #7

Merged
merged 3 commits into from Oct 13, 2020
Merged

Add types #7

merged 3 commits into from Oct 13, 2020

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Oct 13, 2020

Types!

@wooorm wooorm added ☂️ area/types This affects typings 🙆 yes/confirmed This is confirmed and ready to be worked on 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Oct 13, 2020
@wooorm wooorm mentioned this pull request Oct 13, 2020
Merged
3 tasks
ChristianMurphy
ChristianMurphy approved these changes Oct 13, 2020
View reviewed changes
types/index.d.ts Show resolved Hide resolved
ChristianMurphy
ChristianMurphy approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wooorm!

@wooorm wooorm merged commit f7671da into main Oct 13, 2020
@wooorm wooorm deleted the types branch October 13, 2020 16:11
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Oct 13, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@BarryThePenguin BarryThePenguin Awaiting requested review from BarryThePenguin

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wooorm @ChristianMurphy