Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an ordered listing #69

Merged
merged 5 commits into from Nov 19, 2020
Merged

Add support for an ordered listing #69

merged 5 commits into from Nov 19, 2020

Conversation

thomasjungblut
Copy link
Contributor

Hey,

apologies in advance for the random PR, I'm coming from the discussion at gatsby-remark-table-of-contents-8, which is a pretty simple wrapper around the MDAST for GatsbyJS.

The goal is to pass a new "ordered" setting around and manifest it in the whole TOC tree.
Happy to make any adjustments.

Cheers,
Thomas

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

.gitignore Outdated Show resolved Hide resolved
lib/contents.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
test/fixtures/headings-ordered/config.json Outdated Show resolved Hide resolved
thomasjungblut and others added 4 commits November 18, 2020 18:02
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
@thomasjungblut
Copy link
Contributor Author

Thanks for the review @wooorm, everything applied.

Copy link
Member

@BarryThePenguin BarryThePenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great! 🎉

@thomasjungblut
Copy link
Contributor Author

thanks!, let's merge? 🚀

@wooorm wooorm merged commit 44811ad into syntax-tree:main Nov 19, 2020
@wooorm
Copy link
Member

wooorm commented Nov 19, 2020

Thanks @thomasjungblut, released!

@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Nov 19, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

None yet

3 participants