Use ESM #71
Merged
Use ESM #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
ChristianMurphy
approved these changes
Apr 25, 2021
BarryThePenguin
approved these changes
Apr 25, 2021
|
@BarryThePenguin any particular parts or things that changed you found interesting? Agreed, but curious to hear your thoughts! |
Comment on lines
-16
to
+19
| console.log('javascript', require('util').inspect(table, {depth: 3})) | ||
| console.log('javascript', inspect(table, {depth: 3})) |
There was a problem hiding this comment.
This is probably more specific to remark-usage being used but..
I've never really been a fan of using require inline like this. ESM forces static imports to be defined at the beginning of the module.
Sure, there are dynamic imports. However, now that code path needs to be asynchronous
Comment on lines
-39
to
+38
| var siblings = parent.children | ||
| var tail = siblings[siblings.length - 1] | ||
| var index = -1 | ||
| var item | ||
| const siblings = parent.children | ||
| const tail = siblings[siblings.length - 1] | ||
| let index = -1 |
There was a problem hiding this comment.
Not ESM related.. but the distinction of which var became a let or const is interesting. Seeing the distinction like this is useful 👍🏻
Also, the scope of item changing from function scope to block scope 👀
github-actions
bot
added
🤷 no/invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Note: I’ll update
mdast-util-to-stringlater, which causes a small change in output. And I’ll update to use JSDoc based types in another PR too — turned off dtslint meanwhile