Refactor code-style

syntax-tree · Jul 21, 2021 · 72cbf43 · 72cbf43
1 parent b1f9134
commit 72cbf43
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 22 deletions.
diff --git a/index.js b/index.js
@@ -26,10 +26,10 @@ export const findAllBefore =
      * @returns {Array.<Node>}
      */
     function (parent, index, test) {
-      var is = convert(test)
+      const is = convert(test)
       /** @type {Array.<Node>} */
-      var results = []
-      var offset = -1
+      const results = []
+      let offset = -1
 
       if (!parent || !parent.type || !parent.children) {
         throw new Error('Expected parent node')

diff --git a/package.json b/package.json
@@ -64,11 +64,7 @@
     "trailingComma": "none"
   },
   "xo": {
-    "prettier": true,
-    "rules": {
-      "no-var": "off",
-      "prefer-arrow-callback": "off"
-    }
+    "prettier": true
   },
   "remarkConfig": {
     "plugins": [

diff --git a/readme.md b/readme.md
@@ -27,7 +27,7 @@ npm install unist-util-find-all-before
 import {u} from 'unist-builder'
 import {findAllBefore} from 'unist-util-find-all-before'
 
-var tree = u('tree', [
+const tree = u('tree', [
   u('leaf', 'leaf 1'),
   u('node', [u('leaf', 'leaf 2'), u('leaf', 'leaf 3')]),
   u('leaf', 'leaf 4'),
@@ -37,7 +37,7 @@ var tree = u('tree', [
   u('leaf', 'leaf 7')
 ])
 
-var leaf6 = tree.children[4]
+const leaf6 = tree.children[4]
 
 console.log(findAllBefore(tree, leaf6, 'leaf'))
 ```

diff --git a/test.js b/test.js
@@ -2,14 +2,14 @@ import test from 'tape'
 import remark from 'remark'
 import {findAllBefore} from './index.js'
 
-var tree = remark().parse('Some _emphasis_, **importance**, and `code`.')
+const tree = remark().parse('Some _emphasis_, **importance**, and `code`.')
 // @ts-expect-error hush.
-var paragraph = tree.children[0]
-var children = paragraph.children
+const paragraph = tree.children[0]
+const children = paragraph.children
 
-test('unist-util-find-all-before', function (t) {
+test('unist-util-find-all-before', (t) => {
   t.throws(
-    function () {
+    () => {
       // @ts-expect-error runtime.
       findAllBefore()
     },
@@ -18,7 +18,7 @@ test('unist-util-find-all-before', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-expect-error runtime.
       findAllBefore({type: 'foo'})
     },
@@ -27,7 +27,7 @@ test('unist-util-find-all-before', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-expect-error runtime.
       findAllBefore({type: 'foo', children: []})
     },
@@ -36,23 +36,23 @@ test('unist-util-find-all-before', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       findAllBefore({type: 'foo', children: []}, -1)
     },
     /Expected positive finite number as index/,
     'should fail without index (#2)'
   )
 
   t.throws(
-    function () {
+    () => {
       findAllBefore({type: 'foo', children: []}, {type: 'bar'})
     },
     /Expected child node or index/,
     'should fail without index (#3)'
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-expect-error runtime.
       findAllBefore({type: 'foo', children: [{type: 'bar'}]}, 1, false)
     },
@@ -61,7 +61,7 @@ test('unist-util-find-all-before', function (t) {
   )
 
   t.throws(
-    function () {
+    () => {
       // @ts-expect-error runtime.
       findAllBefore({type: 'foo', children: [{type: 'bar'}]}, 1, true)
     },
@@ -137,7 +137,7 @@ test('unist-util-find-all-before', function (t) {
     'should return children when given a `type` and existing (#4)'
   )
 
-  var result = children.slice(4)
+  const result = children.slice(4)
 
   t.deepEqual(
     findAllBefore(paragraph, 100, test),