-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency #13
Conversation
Related to #12
@wooorm, I didn't know which version to choose, so I just picked the latest |
I could also use peer deps instead of deps, WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ayc0!
The rule of thumb for picking versions in unified.
Generally go for the first release of the latest major and use ^
to allow for newer releases in the same line.
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
Thanks @ChristianMurphy And what about deps vs peerDeps? |
I'd lean |
This comment has been minimized.
This comment has been minimized.
Thanks! |
Thank you Benjamin! |
Initial checklist
Description of changes
Add
@types/unist
in dependencies (in the deps and not devDeps, because those types are exposed to users)Related to #12